Replace Glide with Coil #403
Conversation
...dev/arkbuilders/navigator/presentation/screen/gallery/previewpager/PreviewImageViewHolder.kt
Show resolved
Hide resolved
| if (!subsamplingImageLoadFailed) { | ||
| if (ivZoom.isZoomed) { | ||
| progress.isVisible = true | ||
| ivZoom.isZoomEnabled = false | ||
| ivZoom.resetZoom() | ||
| } |
There was a problem hiding this comment.
We can use positive boolean to improve this block of code. See https://testing.googleblog.com/2023/10/improve-readability-with-positive.html
| if (!subsamplingImageLoadFailed) { | |
| if (ivZoom.isZoomed) { | |
| progress.isVisible = true | |
| ivZoom.isZoomEnabled = false | |
| ivZoom.resetZoom() | |
| } | |
| if (subsamplingImageLoadSuccess) { | |
| with(ivZoom) { | |
| if (isZoomed) { | |
| isVisible = true | |
| isZoomEnabled = false | |
| resetZoom() | |
| } | |
| } | |
| } |
There was a problem hiding this comment.
This condition should only be met until subsampling image fails. We cannot claim that subsampling image was successfully loaded from very beginning. It hasn't failed or been successful yet. But I'll add comments to make it clear
...dev/arkbuilders/navigator/presentation/screen/gallery/previewpager/PreviewImageViewHolder.kt
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
|
@mdrlzy the PR in the arklib-android has been merged: |
kirillt
had a problem deploying
to
Development
GitHub Actions
Failure
kirillt
had a problem deploying
to
Development
GitHub Actions
Failure
|
@mdrlzy any chance to complete this one? 😉 |
Yeah, but there is no new release of |
|
@mdrlzy thanks for letting know, I've published |
|
Test files |
|
No description provided.