Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure project #393

Closed
wants to merge 4 commits into from
Closed

Restructure project #393

wants to merge 4 commits into from

Conversation

hieuwu
Copy link
Collaborator

@hieuwu hieuwu commented Oct 14, 2023 •
edited
Loading

⭐️ Summary

Restructure project from space.taran to dev.arkbuilders

🖼 Screenshot

Screenshot 2023-10-14 at 22 05 32 Screenshot 2023-10-14 at 20 59 42

@hieuwu hieuwu self-assigned this Oct 14, 2023
@hieuwu hieuwu temporarily deployed to Development October 14, 2023 13:59 — with GitHub Actions Inactive
@hieuwu hieuwu temporarily deployed to Development October 14, 2023 14:08 — with GitHub Actions Inactive
@hieuwu hieuwu temporarily deployed to Development October 14, 2023 14:11 — with GitHub Actions Inactive
@hieuwu hieuwu temporarily deployed to Development October 14, 2023 14:11 — with GitHub Actions Inactive
@hieuwu hieuwu requested review from kirillt and mdrlzy October 14, 2023 14:18
@hieuwu hieuwu temporarily deployed to Development October 14, 2023 14:21 — with GitHub Actions Inactive
@hieuwu hieuwu temporarily deployed to Development October 14, 2023 14:30 — with GitHub Actions Inactive
@hieuwu hieuwu temporarily deployed to Development October 14, 2023 14:33 — with GitHub Actions Inactive
@hieuwu hieuwu temporarily deployed to Development October 14, 2023 14:33 — with GitHub Actions Inactive
@hieuwu hieuwu temporarily deployed to Development October 14, 2023 15:05 — with GitHub Actions Inactive
@hieuwu hieuwu temporarily deployed to Development October 14, 2023 15:12 — with GitHub Actions Inactive
@hieuwu hieuwu temporarily deployed to Development October 14, 2023 15:16 — with GitHub Actions Inactive
@hieuwu hieuwu temporarily deployed to Development October 14, 2023 15:16 — with GitHub Actions Inactive
@tuancoltech
Copy link
Collaborator

@hieuwu @kirillt : This might be conflicting with what we've been doing in this branch: rename-package?
We are doing the same work !

@hieuwu
Copy link
Collaborator Author

hieuwu commented Oct 14, 2023

@hieuwu @kirillt : This might be conflicting with what we've been doing in this branch: rename-package? We are doing the same work !

No worries, there might be miscommunication here . As @kirillt told me to work on this. Although this conflicts with rename-package, let's use this as a reference because rename-package does not work. Feel free to close this PR when the job is done

@kirillt
Copy link
Member

kirillt commented Oct 14, 2023

@tuancoltech sorry, I indeed asked @hieuwu to help with this.. But we can compare the changes in both PRs since it's error-prone kind of work, so both PRs are useful.

@kirillt kirillt mentioned this pull request Oct 15, 2023
Closed
@tuancoltech
Copy link
Collaborator

@hieuwu We've finalized the changes in rename-package which serves the same purpose as of this PR.
Could you take a look and see if there's any differences between the two?

#387

@kirillt
Copy link
Member

kirillt commented Oct 18, 2023

Good PR, we've merged the similar PR, seems to be almost same.

@kirillt kirillt closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillt kirillt Awaiting requested review from kirillt

@mdrlzy mdrlzy Awaiting requested review from mdrlzy

Assignees

@hieuwu hieuwu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hieuwu @tuancoltech @kirillt