File Monitoring #107
Closed
File Monitoring #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrlzy
force-pushed
the
model-refactoring
branch
from
678d4e5 to
9a005f8
Compare
|
@mdrlzy could you list issues which this PR solves? |
kirillt
reviewed
Oct 26, 2021
app/src/main/java/space/taran/arknavigator/mvp/model/RootAndFav.kt
Outdated
Show resolved
Hide resolved
kirillt
reviewed
Oct 26, 2021
app/src/main/java/space/taran/arknavigator/mvp/model/RootAndFav.kt
Outdated
Show resolved
Hide resolved
mdrlzy
force-pushed
the
model-refactoring
branch
from
9a005f8 to
88c4f51
Compare
kirillt
reviewed
Oct 29, 2021
|
|
||
| class FSMonitoring( | ||
| val indexCache: IndexCache, | ||
| val tagsCache: TagsCache, |
| class FSMonitoring( | ||
| val indexCache: IndexCache, | ||
| val tagsCache: TagsCache, | ||
| val appScope: CoroutineScope |
| } | ||
| } | ||
|
|
||
| private fun onDelete(root: Path, directory: Path, eventPath: Path) = appScope.launch(Dispatchers.Default) { |
| tagsCache.remove(id) | ||
| } | ||
|
|
||
| private fun onMovedFrom(root: Path, directory: Path, eventPath: Path) = appScope.launch(Dispatchers.Default) { |
| indexCache.onResourceDeleted(root, eventPath) | ||
| } | ||
|
|
||
| private fun onMovedTo(root: Path, directory: Path, eventPath: Path) = appScope.launch(Dispatchers.Default) { |
|
|
||
| class RecursiveDirectoryObserver( | ||
| private val fsMonitoring: FSMonitoring, | ||
| private val root: String |
There was a problem hiding this comment.
Let's not use strings to work with paths unless it's not impossible.
val root: Path
| val parent: String = stack.pop() | ||
| directoryObservers.add(DirectoryObserver.create(this, parent)) | ||
| val path = File(parent) | ||
| val files: Array<File> = path.listFiles() ?: continue |
There was a problem hiding this comment.
Let's use newer java.nio.file package.
Files.list(path)
|
|
||
| override fun onEvent(event: Int, path: String?) { | ||
| val eventCode = event and ALL_EVENTS | ||
| val eventPath = path?.let { "$directory/$path" } |
There was a problem hiding this comment.
| fun log(directory: String, event: Int, eventPath: String?) { | ||
| val eventName = provideEventName(event) | ||
| eventName?.let { | ||
| Timber.d("$eventName \n Directory: $directory \n Path: $eventPath") |
There was a problem hiding this comment.
Why not use plain Log.d with filesystem tag?
| @@ -22,6 +32,7 @@ class MainPresenter: MvpPresenter<MainView>() { | |||
|
|
|||
| fun permsGranted() { | |||
| Log.d(MAIN, "creating Folders screen") | |||
| presenterScope.launch { indexingEngine.reindex() } | |||
There was a problem hiding this comment.
Reindexing all roots during start-up can take unnecessarily long time.
|
Renamed branch into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.