Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vagrant stuff, pointing towards WSL2 #6

Merged
merged 2 commits into from
Nov 21, 2024
Merged

remove vagrant stuff, pointing towards WSL2 #6

merged 2 commits into from
Nov 21, 2024

Conversation

ajharvie
Copy link
Contributor

Suggesting use of WSL2 (as recommended by official docs) over vagrant/VM solution for use on Windows

@ajharvie
Copy link
Contributor Author

Also, have just updated the actions so they'll pass!

pull_request:
branches:
- main
workflow_dispatch:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10 support always having a workflow_dispatch option for rebuilding on the fly, saves so many spurious commits.

Copy link

@murphyqm murphyqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that build works smoothly locally; all seems right.

@ajharvie ajharvie merged commit 2e99d91 into main Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants