Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recalc with updated SH12A #9

Merged
merged 7 commits into from
Mar 26, 2024

Conversation

nbassler
Copy link
Member

@nbassler nbassler commented Mar 4, 2024

Recalculation and testing of fix for https://gitlab.au.dk/shieldhit/shieldhit/-/issues/439

@nbassler nbassler linked an issue Mar 4, 2024 that may be closed by this pull request
@nbassler
Copy link
Member Author

nbassler commented Mar 4, 2024

v1.0.1-45-g9c9cc584 introduces new issue fd04f1b#diff-6c2d8efdda9ba26991b3ebbf0d0655045dc879e3a3f1b116cd4cf00980607e77
NANs in water scorer.

data/sh12a/results/plan2/NB_Z_narrow_dose_water__p2.png

@nbassler
Copy link
Member Author

nbassler commented Mar 4, 2024

debugging

     Primary particle no.      281000      ETR:   0 hours 29 minutes 13 seconds
*** Warning:  SH_MDEDX_WRAP: z > 20 unavailable. (z,a):          21          39
*** Warning:  SH_MDEDX_WRAP: z > 20 unavailable. (z,a):          21          39
---------------------------------------------------Print particle:
  jpart  = 25
  PDG    = 1000210390
  id     = 1
  Z      = 21
  A      = 39
  amass  =  36314.09731 MeV/c**2
  amu    =     38.98479 u
  gen    = 1
  nprim  = 281484
  weight = 1.000000
POINT Override settings: 4 1.000000 -nan
POINT val = energy * volinv / rho_med * mstpr = 1.230358 * 2.531646 / 1.032000 * -nan =  -nan
POINT NAN in scoring

The nans are due to missing stopping power tables for fragments with z > 21. (solid water medium has some heavier elements added)

@nbassler
Copy link
Member Author

nbassler commented Mar 4, 2024

fixed in SH12A v1.0.1-49-gb2876ad9

@nbassler
Copy link
Member Author

nbassler commented Mar 9, 2024

Issue #3 primaries still weird, but uncertainties are probably quite ok. @mdsainth maybe take a quick look, you can average the 20 bin target bins if it helps.

If you agree that the test plan looks OK, lets recalculate all plans, but as you suggested for a single target bin, and then merge this branch into master.

filed here: DataMedSci/pymchelper#718

@nbassler
Copy link
Member Author

Is queued for recalculation, but will be closed when #6 is fixed too.

@nbassler
Copy link
Member Author

FYI: average of the same 200 jobs with a new test version of pymchelper

DataMedSci/pymchelper#723

now primaries reported should work and be consistent.

Error bars are however missing now, still TODO.

@nbassler
Copy link
Member Author

@mdsainth errorbars there now ... tell us if you see something weird

@nbassler
Copy link
Member Author

Copy link
Member Author

@nbassler nbassler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me

@nbassler nbassler requested a review from grzanka March 26, 2024 11:43
@nbassler nbassler self-assigned this Mar 26, 2024
@nbassler nbassler marked this pull request as ready for review March 26, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scoring target DLET for plan 2 strangely low
2 participants