-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recalc with updated SH12A #9
Conversation
v1.0.1-45-g9c9cc584 introduces new issue fd04f1b#diff-6c2d8efdda9ba26991b3ebbf0d0655045dc879e3a3f1b116cd4cf00980607e77 data/sh12a/results/plan2/NB_Z_narrow_dose_water__p2.png |
debugging
The nans are due to missing stopping power tables for fragments with z > 21. (solid water medium has some heavier elements added) |
fixed in SH12A v1.0.1-49-gb2876ad9 |
Issue #3 primaries still weird, but uncertainties are probably quite ok. @mdsainth maybe take a quick look, you can average the 20 bin target bins if it helps. If you agree that the test plan looks OK, lets recalculate all plans, but as you suggested for a single target bin, and then merge this branch into master. filed here: DataMedSci/pymchelper#718 |
Is queued for recalculation, but will be closed when #6 is fixed too. |
FYI: average of the same 200 jobs with a new test version of pymchelper now primaries reported should work and be consistent. Error bars are however missing now, still TODO. |
@mdsainth errorbars there now ... tell us if you see something weird |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me
Recalculation and testing of fix for https://gitlab.au.dk/shieldhit/shieldhit/-/issues/439