Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules when they have changed #38

Merged
merged 3 commits into from
Apr 5, 2015

Conversation

farridav
Copy link

@farridav farridav commented Apr 3, 2015

When reading through the nginx module unpacking, and also seeing a commit from @otakup0pe I noticed we are not updating modules when they change (because of the creates arg)

Changing this behaviour so that downloaded nginx modules are used from their extracted location, (which has a version number in it) so if a module version changes, a new one is downloaded, and nginx is recompiled using the newly extracted module (rather than the old one, or a combination of old and new)

@farridav farridav force-pushed the farridav/update_module_on_change branch from 0f6c25a to 7791998 Compare April 3, 2015 10:15
@farridav farridav force-pushed the farridav/update_module_on_change branch from 82741fe to e58819d Compare April 4, 2015 21:27
@otakup0pe
Copy link
Member

This LGTM. We need to keep this style when implementing #4, #2, and whatever else may come.

otakup0pe added a commit that referenced this pull request Apr 5, 2015
@otakup0pe otakup0pe merged commit a01e14c into master Apr 5, 2015
@otakup0pe otakup0pe deleted the farridav/update_module_on_change branch April 5, 2015 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants