Update modules when they have changed #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading through the nginx module unpacking, and also seeing a commit from @otakup0pe I noticed we are not updating modules when they change (because of the
creates
arg)Changing this behaviour so that downloaded nginx modules are used from their extracted location, (which has a version number in it) so if a module version changes, a new one is downloaded, and nginx is recompiled using the newly extracted module (rather than the old one, or a combination of old and new)