Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Don't do COM initialization for "syn-only" reg #757

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

cookpa
Copy link
Member

@cookpa cookpa commented Dec 12, 2024

No description provided.

@cookpa
Copy link
Member Author

cookpa commented Dec 12, 2024

@stnava @ntustison I have got this doing a default Identity initial transform for the "syn only" transforms:

    deformable_only_transforms = ["SyNOnly", "antsRegistrationSyN[so]", "antsRegistrationSyNQuick[so]",
                                  "antsRegistrationSyNRepro[so]", "antsRegistrationSyNQuickRepro[so]",
                                  "antsRegistrationSyN[bo]", "antsRegistrationSyNQuick[bo]",
                                  "antsRegistrationSyNRepro[bo]", "antsRegistrationSyNQuickRepro[bo]"]

I'm going to add the TV* as well

@cookpa
Copy link
Member Author

cookpa commented Dec 12, 2024

Actually, question: the initial transform

          # '-r', initx,

is simply commented out for the TV methods, so you actually can't pass an initial transform. Is it OK if I let people specify an initial transform with default of Identity?

@ntustison
Copy link
Member

Yeah, that sounds reasonable to me.

@coveralls
Copy link

coveralls commented Dec 12, 2024

Coverage Status

coverage: 79.673% (+0.01%) from 79.662%
when pulling d1590d5 on syn_only_init
into 80826f5 on master.

@cookpa cookpa marked this pull request as ready for review December 12, 2024 03:30
@cookpa cookpa merged commit c06c34f into master Dec 12, 2024
3 checks passed
@cookpa cookpa deleted the syn_only_init branch December 12, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants