Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add functionality for specifying def. xfrm #752

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

ntustison
Copy link
Member

No description provided.

ants/registration/registration.py Outdated Show resolved Hide resolved
ants/registration/registration.py Outdated Show resolved Hide resolved
@cookpa
Copy link
Member

cookpa commented Dec 3, 2024

Hi @ntustison , one general point related to this: several users have been tripped up by the fact that
"syn only" starts with COM translation. Would it make sense to include an "initial_transform" in the "def.xfrm" spec, with a default of 'Identity'?

@coveralls
Copy link

Coverage Status

coverage: 79.662% (-0.1%) from 79.806%
when pulling 25986bf on LabelRegList
into 3cf8ac9 on master.

@ntustison
Copy link
Member Author

Hi @ntustison , one general point related to this: several users have been tripped up by the fact that "syn only" starts with COM translation. Would it make sense to include an "initial_transform" in the "def.xfrm" spec, with a default of 'Identity'?

Are we talking about this functionality or ants.registration?

@cookpa
Copy link
Member

cookpa commented Dec 3, 2024

Hi @ntustison , one general point related to this: several users have been tripped up by the fact that "syn only" starts with COM translation. Would it make sense to include an "initial_transform" in the "def.xfrm" spec, with a default of 'Identity'?

Are we talking about this functionality or ants.registration?

Sorry, yeah this is an ants.registration problem - moot if using the label method.

@ntustison
Copy link
Member Author

Okay, that's what I thought I remembered you mentioning a week or so ago in one of the issues you were addressing. I agree that this is a problem and the interface could, perhaps more generally, use some rethinking. Let me take a look and get back to you once I get this particular work settled (in a week or so).

@ntustison ntustison merged commit 2f55742 into master Dec 3, 2024
3 checks passed
@ntustison ntustison deleted the LabelRegList branch December 3, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants