Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flux Index Bugs #159

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Flux Index Bugs #159

merged 2 commits into from
Aug 12, 2024

Conversation

ajnonaka
Copy link
Contributor

@ajnonaka ajnonaka commented Aug 8, 2024

Thanks to Changho for spotting both of these.

Fixed a bug in the z ChiX stencil.

Fixed an error in the z heat flux indexing which doesn't ultimately affect the simulation since it's summed into the same location in memory in the end anyway regression tests will likely change when this is merged.

fixed an error in the z heat flux indexing which doesn't ultimately affect the simulation since it's summed into the same location in memory in the end anyway
regression tests will likely change when this is merged
@ajnonaka ajnonaka requested review from changhokim and isriva August 8, 2024 15:20
@isriva
Copy link
Contributor

isriva commented Aug 8, 2024

good catches! there is a small modification I would suggest in line 1364 above. but apart from that looks good to me!
interesting this was never caught -- I think this is because we only did equilibrium tests in z-direction (which would likely not be affected by this), whereas all nonequilibrium simulations were done by applying a gradient in x- and y- directions.

@ajnonaka
Copy link
Contributor Author

ajnonaka commented Aug 8, 2024

What line 1364 modification are you suggesting? @isriva

@isriva
Copy link
Contributor

isriva commented Aug 8, 2024

@ajnonaka line 1364 of flucStag.cpp should be:
Real ChiX = 0.5*(chi(i,j,k-1,ns)*prim(i,j,k-1,6+nspecies+ns)+chi(i,j,k,ns)*prim(i,j,k,6+nspecies+ns));

@ajnonaka
Copy link
Contributor Author

ajnonaka commented Aug 8, 2024

@isriva fixed!

@ajnonaka ajnonaka merged commit a09bf82 into main Aug 12, 2024
2 checks passed
@ajnonaka ajnonaka deleted the flux_index_bug branch January 3, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants