-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HEFFTE support in compressible FHD + Advanced diagnostics for compressible turbulence #146
Conversation
@ajnonaka please check the detailed PR description on how to compile using HEFFTE on various machines. |
Copy data to host first before calling MPI reduce.
@isriva At this point is there a need to keep heffte support in this branch and FHDeX in general, or can we go all-in on AMReX-FFT? I'd like to update all of FHDeX but want this PR (possibly fixed) and merged first to avoid conflicts later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for merging. I updated all the makefiles for all tests to ensure they still run and they all pass regression.
This major PR now includes the capability to do distributed FFT (using HEFFTE). This is currently implemented for compressible staggered turbulence codes, but can be easily ported to other codes. HEFFTE works with the three major backends: FFTW, cuFFT and rocFFT for usage on CPUs, and NVIDIA and AMD GPUs. Some other developments in this PR include:
Compile-time options: This PR now enables several more compile time options described below:
DO_TURB
: This option switches on/off the compilation of turbulence-specific codes -- not needed if additional turbulence stats and turbulent forcing is not desired.USE_HEFFTE_FFTW
: Do distributed FFT using HeFFTe (https://github.com/icl-utk-edu/heffte) for turbulence statistics using FFTW backend (need FFTW libraries)USE_HEFFTE_CUFFT
: Do distributed FFT using HeFFTe (https://github.com/icl-utk-edu/heffte) for turbulence statistics using cuFFT backend (needs NVIDIA cuFFT libraries)USE_HEFFTE_ROCFFT
: Do distributed FFT using HeFFTe (https://github.com/icl-utk-edu/heffte) for turbulence statistics using rocFFT backend (needs AMD rocFFT libraries)It is possible to do various mixes, such as CUDA compilation of the code using
USE_CUDA=TRUE
and still FFTW backend usingUSE_HEFFTE_FFTW=TRUE
etc., as long as the required libraries are available.Distributed FFTs using
USE_HEFFTE_FFTW=TRUE
,USE_HEFFTE_CUFFT=TRUE
orUSE_HEFFTE_ROCFFT=TRUE
requires installing HeFFTe (https://github.com/icl-utk-edu/heffte). Please follow the steps below:git clone https://github.com/isriva/heffte.git
exec/compressible_stag
using any of the HEFFTE backend flags described abovebuild_frontier.sh
inexec/compressible_stag
to compile on Frontier. One can changes some compile time flags such asDO_TURB
andMAX_SPECIES