Fix swapped sin and cos in sneut #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts all the benchmark updates made in AMReX-Astro#1379, as the actual changes should be very minor.
zingale
approved these changes
Nov 6, 2023
|
oh, this went to main. I'll push it to development too |
yut23
added a commit
to yut23/pynucastro
that referenced
this pull request
Nov 7, 2023
yut23
added a commit
to pynucastro/pynucastro
that referenced
this pull request
Nov 7, 2023
See AMReX-Astro/Microphysics#1380. The subch_approx benchmark now matches the version before #677, but the ECSN one has changed (which matches what we saw with the benchmarks in Microphysics).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.