-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use adaptive stepping for exact Riemann integration #2869
use adaptive stepping for exact Riemann integration #2869
Conversation
this speeds things up by 2x
this seems to all work now
Here are some of my notes for this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great, there is only one issue:
In riemman_star_state.H
, after ustar_l
and ustar_r
are computed of each iteration, in line 141 we obtain :
ustar = 0.5_rt * (ustar_l + ustar_r);
This expression is not right, the actual expression is:
ustar = (Z_l * ustar_l + Z_r * ustar_r)/(Z_l + Z_r)
In accordance with Van Leer [22] eq A3. I double checked it to be sure.
I don't think that the expression I am using is wrong. If the iteration were successful, then u_star,l = u_star,r, so this average is just dealing with the tolerance of the solver. |
it is actually just a different average, the Z's there are the slope at the intersection, which should be the same if we've converged the root finding. |
PR summary
There are 2 main changes here:
This changes results to roundoff / tol error, as expected.
PR motivation
PR checklist
CHANGES
file has been updated, if appropriate