Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the wdmerger case when the 2 stars are very close #2829

Merged
merged 8 commits into from
Apr 22, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Apr 20, 2024

the initialization was overlapping and doing bad things now we simply look at which model provides the largest density at a location and use that.

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

the initialization was overlapping and doing bad things
now we simply look at which model provides the largest density
at a location and use that.
@zingale
Copy link
Member Author

zingale commented Apr 20, 2024

Here's the wdmerger 2D collision test case now:

image

compare to the image in #2824

@zingale
Copy link
Member Author

zingale commented Apr 20, 2024

Copy link
Collaborator

@yut23 yut23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The velocities need to be corrected too. I think the same condition should work.

@zingale
Copy link
Member Author

zingale commented Apr 21, 2024

velocities updated, but I want to rerun the suite on this now.

@zingale zingale merged commit e5be91e into AMReX-Astro:development Apr 22, 2024
25 checks passed
@zingale zingale deleted the fix_close_stars branch April 22, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants