define runtime params in .cpp instead of *_declares.H #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yut23
reviewed
Mar 26, 2024
Co-authored-by: Eric T. Johnson <[email protected]>
|
We should sort |
yut23
reviewed
Mar 26, 2024
|
added the sort on namespaces |
yut23
reviewed
Mar 26, 2024
Co-authored-by: Eric T. Johnson <[email protected]>
|
okay, I removed the redundant sorts |
yut23
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a potential ODR problem with *_declares.H, which is where we did the actual
definition of the runtime parameters. Now we output a single runtime_params.cpp
that has all of the runtime parameters defined in source instead of headers.
This also removes padding from the struct that we can alternately use for runtime
params
PR summary
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate