Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update detonation problem for nse_net #2765

Merged
merged 3 commits into from
Mar 8, 2024
Merged

update detonation problem for nse_net #2765

merged 3 commits into from
Mar 8, 2024

Conversation

zhichen3
Copy link
Collaborator

@zhichen3 zhichen3 commented Mar 5, 2024 •
edited
Loading

  • Update detonation problem for nse_net. Use subch_base as the default network. Changed the initial condition to not explicitly start with NSE mass fractions, which I think is more realistic.
  • Updated the profile.py script to allow plotting IN_NSE quantity.
  • Changed default integration method to simplified-sdc.

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale merged commit 25cc6d8 into AMReX-Astro:development Mar 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhichen3 @zingale @yut23