Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEVER MERGE THIS!!!] constexpr the runtime parameters #2702

Closed

Conversation

zingale
Copy link
Member

@zingale zingale commented Jan 4, 2024

PR summary

This is an experiment to see if keeping the runtime parameters as constexpr instead of managed helps with later
versions of ROCm. Note: the values are compiled in, so they will need to be hacked to override the defaults for a particular problem.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member Author

zingale commented Jan 4, 2024

run this together with this Microphysics PR:
AMReX-Astro/Microphysics#1441

these hardcode the parameters for the subchandra problem, which is one of the problems that fails with later versions of ROCm

@zingale
Copy link
Member Author

zingale commented Jan 4, 2024

The way this works is that we pass --constexpr to the python scripts that write the parameters headers. This changes them to declare them as constexpr instead of (extern) managed. The values are no hardcoded in, and there are no parmparse queries for them.

@zingale zingale closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant