clean up linear interpolation #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #2663 |
5 tasks
maxpkatz
reviewed
Dec 17, 2023
|
There are now a bunch of unit tests in These test what happens when you ask for an r outside of the model range and if you get exactly the model data (to roundoff) if you ask for an r which is exactly a model point. |
|
okay, looking at this more. The old interpolation did work fine, in the sense that it had a general enough scheme to check if we need to use i, i-1 or i, i+1 for the bulk of the interpolation. In fact, the test suite is just roundoff diffs now: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2023-12-17/index.html |
zingale
changed the title
maxpkatz
reviewed
Dec 22, 2023
Util/model_parser/model_parser.H
Outdated
|
|
||
| } | ||
| // safety check to make sure interp lies within the bounding points | ||
| Real minvar = std::min(model::profile(model_index).state(id+1, var_index), |
There was a problem hiding this comment.
Do we want this for r < profile.r(0)?
There was a problem hiding this comment.
indeed, probably not. That's a good point.
maxpkatz
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locate() function was returning the index of the zone that is higher than the input coordinate r. The logic in interpolate accounted for this, but things were more complex than they need be. This simplifies locate and the linear interpolation.
It also adds a unit test to help understand what's happening.
PR summary
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate