Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rad CI benchmark #2662

Merged
merged 4 commits into from
Nov 30, 2023
Merged

update rad CI benchmark #2662

merged 4 commits into from
Nov 30, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Nov 29, 2023 •
edited
Loading

recent changes to fextrema change 0 to -0

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
ignore angular_momentum_z in rad CI
83485ba 
for some reason we get -0 on github but 0 locally
must be a lib difference (hypre?) somewhere
@zingale
whitespac
a774382
@zingale
the diff was due to fextrema
57d6829
@zingale zingale changed the title ignore angular_momentum_z in rad CI update rad CI benchmark Nov 30, 2023
@zingale zingale merged commit 2d523e8 into AMReX-Astro:development Nov 30, 2023
19 checks passed
@zingale zingale deleted the fix_rad_ci branch November 30, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz