New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update convective_flame, bubble_convergence, and hse_convergence #2624

Merged

zingale merged 1 commit into AMReX-Astro:development from zingale:more_model_syncs

Oct 9, 2023

Member

zingale commented Oct 9, 2023

these now get the model size from the_amr_ptr

PR summary

PR motivation

PR checklist

test suite needs to be run on this PR
this PR will change answers in the test suite to more than roundoff level
all newly-added functions have docstrings as per the coding conventions
the CHANGES file has been updated, if appropriate
if appropriate, this change is described in the docs


          update convective_flame, bubble_convergence, and hse_convergence

06a060c

these now get the model size from the_amr_ptr

Member Author

zingale commented Oct 9, 2023

closes #2618

Member Author

zingale commented Oct 9, 2023

tests pass:
http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2023-10-09-007/index.html

maxpkatz approved these changes

View reviewed changes

zingale merged commit 709505e into AMReX-Astro:development

18 checks passed

zingale deleted the more_model_syncs branch

October 9, 2023 20:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet