Feat: Unsaved Changes Modal #2488
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
Deploying akasha-core-framework with
|
| Latest commit: |
2997184
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e3bdfcb4.akasha-world-framework.pages.dev |
| Branch Preview URL: | https://dev-425.akasha-world-framework.pages.dev |
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
SeverS
reviewed
Nov 22, 2024
| * get the appName and navigationUrl from the newUrl state | ||
| */ | ||
| const splitPathNames = new URL(newUrl).pathname.split('/'); | ||
| const appName = splitPathNames.slice(1, 3).join('/'); |
There was a problem hiding this comment.
appName here is not correct, you are assuming that names are always in the form of <namespace>/<appname> which is not the case.
For this specific case you'll need to use singleSpa.navigateToUrl. you have access to singleSpa from the useRootComponentProps
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
Signed-off-by: Josemaria Nriagu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues that will be closed
Testing
Checklist