Fix creating new categories

Fixes #24
AJenbo · Apr 2, 2018 · 9f3c950 · 9f3c950
1 parent 0314669
commit 9f3c950
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/application/inc/Http/Controllers/Admin/CategoryController.php b/application/inc/Http/Controllers/Admin/CategoryController.php
@@ -66,7 +66,7 @@ public function create(Request $request): JsonResponse
             throw new InvalidInput(_('You must enter a title and choose a location for the new category.'));
         }
 
-        $icon = app('orm')->getOne(File::class, $iconId);
+        $icon = $iconId ? app('orm')->getOne(File::class, $iconId) : null;
         $parent = app('orm')->getOne(Category::class, $parentId);
 
         $category = new Category([

diff --git a/tests/Feature/Http/Controllers/Admin/CategoryControllerTest.php b/tests/Feature/Http/Controllers/Admin/CategoryControllerTest.php
@@ -44,6 +44,31 @@ public function testCreate(): void
         );
     }
 
+    public function testCreateNoIcon(): void
+    {
+        $data = [
+            'title'       => 'New title',
+            'parentId'    => -1,
+            'render_mode' => 2,
+            'email'       => '[email protected]',
+            'icon_id'     => null,
+        ];
+
+        $this->json('POST', '/admin/categories/', $data)
+            ->assertResponseStatus(200);
+
+        $this->assertDatabaseHas(
+            'kat',
+            [
+                'navn'    => $data['title'],
+                'bind'    => $data['parentId'],
+                'vis'     => $data['render_mode'],
+                'email'   => $data['email'],
+                'icon_id' => $data['icon_id'],
+            ]
+        );
+    }
+
     public function testCreateNoTitle(): void
     {
         $data = [

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -245,6 +245,11 @@ private function isInDatabase(string $table, array $data): bool
     {
         $sets = [];
         foreach ($data as $filedName => $value) {
+            if ($value === null) {
+                $sets[] = '`' . $filedName . '` IS NULL';
+                continue;
+            }
+
             $sets[] = '`' . $filedName . '` = ' . app('db')->quote($value);
         }
         $query = 'SELECT * FROM `' . $table . '` WHERE ' . implode(' AND ', $sets);