Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in Segmentation's CylindricalGridPhiZ: phi range #1357

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

ybedfer
Copy link
Contributor

@ybedfer ybedfer commented Nov 21, 2024

is now set to [-pi,pi] instead of [0,2pi] if phi IDdescriptor field is signed.

BEGINRELEASENOTES
Bug fix in CylindricalGridPhiZ:

  • In the cellId member method, one now refrains from reducing the phi parameter modulo 2pi when its IDdescriptor is signed.
  • When the offset is null, this means that the phi range is now [-pi,pi], instead of the previously [0,2pi] which is not appropriate for a signed quantity.

ENDRELEASENOTES

Followup of #1353

    is now set to [-pi,pi] instead of [0,2pi] if phi IDdescriptor field is signed.
@andresailer andresailer enabled auto-merge (rebase) November 21, 2024 13:16
Copy link

Test Results

   14 files     14 suites   6h 14m 28s ⏱️
  368 tests   367 ✅ 0 💤 1 ❌
2 531 runs  2 530 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit ecff72e.

@andresailer andresailer merged commit 4a42233 into AIDASoft:master Nov 21, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants