GeoHandler: store shapes in deterministic order #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 14 files 14 suites 7h 5m 1s ⏱️ Results for commit d5238ce. ♻️ This comment has been updated with latest results. |
andresailer
force-pushed
the
constantOrder
branch
from
afebda1 to
d5238ce
Compare
|
@MarkusFrankATcernch With this I get identical GDML files for SiD.xml out of Geant4. The main change is inside |
|
Great. Should we ask Witek to test this branch first ? |
1 task
|
It is apparently too hard to build the LHCb stack to test this. But the GDML comparison with SiD.xml hopefully triggered the same issue. |
1 task
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #1271, I am not sure which of these sets causes the problem, so this is an attempt to get the ball rolling.
BEGINRELEASENOTES
ENDRELEASENOTES