Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace imp module usage #1195

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

paulgessinger
Copy link
Contributor

imp was removed in Python 3.12.

See #1194

BEGINRELEASENOTES

  • Replace usage of the imp module that was removed in Python 3.12 with importlib and types.

ENDRELEASENOTES

@MarkusFrankATcernch
Copy link
Contributor

@paulgessinger Thanks for helping in the maintenance!

@MarkusFrankATcernch MarkusFrankATcernch enabled auto-merge (rebase) December 5, 2023 14:58
@paulgessinger
Copy link
Contributor Author

I think there might be a problem in lower python versions (from the CI output I wasn't sure what the test failures were exactly caused by). I'm trying to debug locally. The replacements I put in should be valid starting in python 3.4, so I don't think it's a fundamental error.

@MarkusFrankATcernch
Copy link
Contributor

Let's see how the tests work out.
Otherwise we can still have a try...except approach trying one method and then the other...

Copy link

github-actions bot commented Dec 5, 2023

Test Results

       6 files         6 suites   6h 33m 15s ⏱️
   356 tests    356 ✔️ 0 💤 0
1 058 runs  1 058 ✔️ 0 💤 0

Results for commit 9f70625.

♻️ This comment has been updated with latest results.

@paulgessinger
Copy link
Contributor Author

paulgessinger commented Dec 6, 2023

Hm, the pytest failures seem to be gone. There's now still two failures in ctest in g4units, but from a quick look they don't seem to be related to the python setup?

@MarkusFrankATcernch
Copy link
Contributor

@paulgessinger Yes. The two problems should be unrelated. I restarted the failing test.
From the output it can also be that the Geant4 tracking setup and the generated track(s) are out of the phase space supported.

@MarkusFrankATcernch MarkusFrankATcernch merged commit 530670e into AIDASoft:master Dec 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants