Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for the standard that Geant4 was compiled with #1191

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Nov 20, 2023

BEGINRELEASENOTES

  • CMake: Add a check for the c++ standard that Geant4 was compiled with, and fail if it is
    different from the one required for DD4hep.

ENDRELEASENOTES

I think failing is the correct behavior instead of a warning, for example. The reason is that there will be some files that will be compiled with the same flags that were used to compile Geant4, which means that it will overwrite whatever version of the standard one is requiring for DD4hep (at least with gcc, who is happy to get two different -std=c++XX flags).

Copy link

Test Results

       6 files         6 suites   6h 42m 25s ⏱️
   356 tests    352 ✔️ 0 💤 4
1 058 runs  1 054 ✔️ 0 💤 4

For more details on these failures, see this check.

Results for commit 91808aa.

@MarkusFrankATcernch MarkusFrankATcernch merged commit f2ad48f into AIDASoft:master Nov 20, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants