Skip to content

Commit

Permalink
Python: remove ddsix and shims
Browse files Browse the repository at this point in the history
  • Loading branch information
andresailer committed Apr 19, 2024
1 parent e250727 commit 6144a4e
Show file tree
Hide file tree
Showing 17 changed files with 7 additions and 973 deletions.
2 changes: 1 addition & 1 deletion .github/scripts/runPythonChecks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ source /cvmfs/sft.cern.ch/lcg/views/${VIEW}/setup.sh
cd /Package

echo "RUNNING FLAKE8 CHECK" && \
find . -name "*.py" -and -not -name 'ddsix.py' -exec flake8 {} +
find . -name "*.py" -exec flake8 {} +
2 changes: 1 addition & 1 deletion .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ jobs:
release-platform: ${{ matrix.LCG }}
run: |
echo "RUNNING FLAKE8 CHECK"
find . -name "*.py" -and -not -name 'ddsix.py' -exec flake8 {} +
find . -name "*.py" -exec flake8 {} +
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ Python:
script:
- source /cvmfs/sft.cern.ch/lcg/views/LCG_102/x86_64-centos7-gcc11-opt/setup.sh
- echo "RUNNING FLAKE8 CHECK"
- find . -name "*.py" -and -not -name 'ddsix.py' -exec flake8 {} +
- find . -name "*.py" -exec flake8 {} +



Expand Down
1 change: 0 additions & 1 deletion DDCore/python/dd4hepFactories.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
import optparse
import logging
import errno
from ddsix.moves import input
from io import open

logger = logging.getLogger(__name__)
Expand Down
5 changes: 2 additions & 3 deletions DDCore/python/dd4hep_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,9 @@ def unicode_2_string(value):
:return: always a str
"""
import ddsix as six
if isinstance(value, (bool, float, six.integer_types)):
if isinstance(value, (bool, float, int)):
value = value
elif isinstance(value, six.string_types):
elif isinstance(value, str):
value = str(value)
elif isinstance(value, bytes):
value = value.decode()
Expand Down
Loading

0 comments on commit 6144a4e

Please sign in to comment.