Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify minimum supported Rust version and check in CI #2726

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Mrmaxmeier
Copy link
Contributor

@Mrmaxmeier Mrmaxmeier commented Nov 26, 2024

Hi,

specifying rust-version= ".." in Cargo.toml is nice because it gives a descriptive error message when people try to use LibAFL on older Rust versions. I've added the MSRV for the core-ish libafl crates and added a check in CI that makes sure these are up-to-date.

Thanks!

Note: The CI failure is unrelated 🙃

@tokatoka
Copy link
Member

we should use 1.82 or 1.78?

@Mrmaxmeier
Copy link
Contributor Author

Mrmaxmeier commented Nov 26, 2024

Bolts and LibAFL-proper use &raw mut STATIC which was introduced in 1.82. I've tested the other crates and some of them also build with lower Rust versions so I've settled with 1.78 which is compatible with the current Cargo.lock format (v4).
I think it's fine for the MSRV of these crates to diverge, since it's all verified in CI and on the off-chance that people don't use all of LibAFL it gives a bit more flexibility.

@tokatoka
Copy link
Member

ok

@tokatoka tokatoka merged commit 6ce447e into AFLplusplus:main Nov 26, 2024
100 of 103 checks passed
@Mrmaxmeier Mrmaxmeier deleted the specify-msrv branch November 26, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants