fix(applications): allow admin access to boardview

AEGEE · Sep 24, 2024 · 0e86397 · 0e86397
1 parent 64a5b03
commit 0e86397
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/events.js b/lib/events.js
@@ -77,8 +77,8 @@ exports.listBodyApplications = async (req, res) => {
         return errors.makeBadRequestError(res, 'bodyId is not a number.');
     }
 
-    // Only visible to board members
-    if (!req.permissions.see_boardview[bodyId]) {
+    // Only visible to board members and admins
+    if (!req.permissions.see_boardview.global && !req.permissions.see_boardview[bodyId]) {
         return errors.makeForbiddenError(res, 'You are not allowed to see this');
     }
 

diff --git a/lib/helpers.js b/lib/helpers.js
@@ -204,7 +204,9 @@ exports.getPermissions = (user, corePermissions, approvePermissions) => {
     permissions.apply_general = hasPermission(corePermissions, 'apply:summeruniversity');
 
     permissions.set_board_comment = {};
-    permissions.see_boardview = {};
+    permissions.see_boardview = {
+        global: hasPermission(corePermissions, 'global:approve_members:summeruniversity')
+    };
 
     const approveBodiesList = getBodiesListFromPermissions(approvePermissions);
     const userBodies = user && Array.isArray(user.bodies) ? user.bodies : [];