Implement option_simple_close
#2967
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
changed the title
option_simple_close (simpler variant)option_simple_close
t-bast
force-pushed
the
option-simple-close-no-state-machine
branch
from
67aa29f to
420298c
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2967 +/- ##
==========================================
- Coverage 86.02% 85.94% -0.09%
==========================================
Files 227 227
Lines 20340 20556 +216
Branches 834 841 +7
==========================================
+ Hits 17498 17666 +168
- Misses 2842 2890 +48
|
t-bast
force-pushed
the
option-simple-close-no-state-machine
branch
from
420298c to
d57c3a7
Compare
This feature adds two new messages: - `closing_complete` sent after exchanging `shutdown` - `closing_sig` sent in response to `closing_complete`
The spec allows the closer to use an OP_RETURN output if their amount is too low when using `option_simple_close`.
We introduce a new `NEGOTIATING_SIMPLE` state where we exchange the `closing_complete` and `closing_sig` messages, and allow RBF-ing previous transactions and updating our closing script. We stay in that state until one of the transactions confirms, or a force close is detected. This is important to ensure we're able to correctly reconnect and negotiate RBF candidates. We keep this separate from the previous `NEGOTIATING` state to make it easier to remove support for the older mutual close protocols once we're confident the network has been upgraded.
t-bast
force-pushed
the
option-simple-close-no-state-machine
branch
from
d57c3a7 to
d5c6021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
option_simple_closeas defined in the last update to lightning/bolts#1096Hopefully this is the last time we change the mutual close protocol! And at some point that will let us entirely remove all the code supporting the two previous mutual close protocols (this is why I kept the code as separate as possible instead of trying to fit into the existing
NEGOTIATINGstate).Note that this is a prerequisite for taproot channels: this protocol allows nodes to safely exchange nonces in
shutdown,closing_completeandclosing_sigto spend a musig2 channel output.This forks off #2747 (which we currently keep in case the final version of the spec chosen matches one of its commits).