Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts for joint deconvolution / array combination #423

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

d-l-walker
Copy link
Contributor

  • Added code to split out and mstransform single channels of 7m data in 833d0cc
  • Added code to do 12m + 7m joint deconvolution and TP feathering, with options for deeper cleaning, relaxed automasking, and using TP data as a startmodel in 934d62c
  • Removed some old, unnecessary scripts in 68b94e5

The code for the joint deconvolution & feathering works end-to-end, but there are still several things to be addressed, including:

  • Initialising mask for automasking with the 12m/7m masks from the PL imaging
  • Figuring out how to parallelise the cleaning (parallel tclean does not work when using the TP as a startmodel)
  • Figuring out how to avoid divergence without having to use obscenely large cyclefactor values
    • generally adding more functionality/improvements

@d-l-walker d-l-walker requested a review from keflavich July 3, 2024 14:39
@keflavich
Copy link
Contributor

I gave a shallow review but happy with it so merging.

@keflavich keflavich merged commit 03f2917 into ACES-CMZ:main Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants