April 2024 updates #418
Merged
April 2024 updates #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
95% of the data without taking this step...)
…s, and switch pipeline to casa 6.5.4-9
…r field am in cleaning
…h doesn't make a whole lot of sense but 🤷
keflavich
added a commit
to keflavich/reduction_ACES
that referenced
this pull request
Jun 1, 2024
* add a split step for continuum cleaning (even though we've now imaged 95% of the data without taking this step...) * remove split approach * verboser text * allow for target_line.ms to be in filenames but not exist * pre-split continuum data * fix up some critical bookkeeping * missed import, more flexible retrieval script * reduce requirements for installation so we can use ACES within CASA * fix typos/errors * dammit, I deleted a bunch of critical .ms files. * more safety checks * bump up cyclefactor for field aa * pblimit for aa back to 0.1, plus extra logging commands * add debug verbosity in imstats, which keeps "failing" when it succeeds, and switch pipeline to casa 6.5.4-9 * minor typo * some mosaic stuff * more sanity checks in make_mosaics and allow for another exception for field am in cleaning * remove bad check * mosaics need a relativethreshold * fix manual cases * pbcor things * giant mosaics of feathered * try to make mosaics work more... * add a velocity of peak map. Try forcing field aj to use original MSes * whitespace * revert aj ms selection: just changing to datacolumn=data worked, which doesn't make a whole lot of sense but 🤷 * fix undefined variable error * add workaround for CI - raise an error at runtime if not in CASA environment * revise mosaicing file finder * try to make product-based images work again * increase verbosity and add manual cubes to max/mom calculations * p: use datacolumn=data * ah, v, and l all need to switch to datacolumn='data' now too. * force datacolumn='data' if that's specified in the tclean pars * for field i, low-frequency, turn up cyclefactor and limit niter * same thing for ag * b was using contsubd data * whitespace * mosaicing & giant cube analysis updates * mosaicing file path fixes, RMS folder choice, and attempt to fix analysis issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First change: added a 'split' step for continuum cleaning