-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scripts for creating feathered, weighted cube mosaic #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Done. |
keflavich
reviewed
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the return ()
for at the end of each? If that's not needed, I'd recommend removing it.
keflavich
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sort of an updated combination of #361 and #365.
Thanks to @ashleythomasbarnes, the master script is much more concise now, and pulls in functions from separate scripts. It now also uses CASA tasks for the regridding to a template (similar to @pyhsiehATalma's approach), which is a lot faster than our previous versions.
I've added functionality to crop and regrid the cubes in velocity prior to mosaicking, as well as the ability to include/exclude 12m data.
The main bottleneck in terms of runtime is the cube cropping and regridding. We can look into the possibility of speeding this step up.
The code still needs more robust error handling, but for now it should work well provided you have the proper directory set up.
[There will be a bunch of style issues that I will fix before merging ...]