Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts for creating feathered, weighted cube mosaic #366

Merged
merged 20 commits into from
Aug 9, 2023

Conversation

d-l-walker
Copy link
Contributor

@d-l-walker d-l-walker commented Jul 28, 2023

This is sort of an updated combination of #361 and #365.

Thanks to @ashleythomasbarnes, the master script is much more concise now, and pulls in functions from separate scripts. It now also uses CASA tasks for the regridding to a template (similar to @pyhsiehATalma's approach), which is a lot faster than our previous versions.

I've added functionality to crop and regrid the cubes in velocity prior to mosaicking, as well as the ability to include/exclude 12m data.

The main bottleneck in terms of runtime is the cube cropping and regridding. We can look into the possibility of speeding this step up.

The code still needs more robust error handling, but for now it should work well provided you have the proper directory set up.

[There will be a bunch of style issues that I will fix before merging ...]

@d-l-walker d-l-walker mentioned this pull request Jul 28, 2023
@d-l-walker
Copy link
Contributor Author

d-l-walker commented Aug 2, 2023

Done.
TODO: Update relevant function(s) to use radio_beam.Beams.common_beam when smoothing the data to a single resolution. This will be more robust than the current approach.

Copy link
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the return () for at the end of each? If that's not needed, I'd recommend removing it.

@d-l-walker d-l-walker merged commit 6adef0c into ACES-CMZ:main Aug 9, 2023
@d-l-walker d-l-walker deleted the feather_weighted_mosaic branch December 13, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants