Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script to combine 7m and TP cubes #340

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pyhsiehATalma
Copy link
Contributor

This script does feather and mosaic cubes of 7m and TP data.

This script does feather and mosaic cubes of 7m and TP data.
Copy link
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few small suggestions

templateIM='CS2-1-temlate-whole-band.image'

import glob
linename=glob.glob('*.image.pbcor')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this to

Suggested change
linename=glob.glob('*.image.pbcor')
linename=glob.glob('*spw33*.image.pbcor')

so that, if you run it in a directory with other cubes in it by accident, you don't change their header frequency value unintentionally


daca={}
dtp={}
with open("dict-aca.txt") as f:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add this file too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's added in #342

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments. I have edited the script accordingly (I think I dit it). Which bottom should I click to submit this change request so you could merge it?

linename=glob.glob('*.image.pbcor')
linename=glob.glob('spw33.image.pbcor')

@keflavich
Copy link
Contributor

@pyhsiehATalma Please check my suggestions and try to fix the style issues so we can merge this.

changing line name from
linename=glob.glob('*.image.pbcor')
to
linename=glob.glob('*spw33*.image.pbcor')
@keflavich
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants