Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger the preview build when labeled #122

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Trigger the preview build when labeled #122

merged 1 commit into from
Oct 5, 2022

Conversation

ccarouge
Copy link
Member

@ccarouge ccarouge commented Oct 5, 2022

ACCESS Community Hive

Thank you for submitting a pull request to the ACCESS Hive Project.

Description

This allows the preview to be built from forks after a human review of the proposed changes.

Note, the preview will never build automatically on creation of the PR even if the PR is from a local branch. It always needs the label to be applied to the PR in order to run.

I have also updated the corresponding text in the contribution guide.

Fixes #121

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue, e.g. dead links)

Checklist:

  • The new content is accessible and located in the appropriate section.
  • My changes do not break navigation and do not generate new warnings
  • I have checked that the links are valid and point to the intended content.
  • I have checked my code/text and corrected any misspellings

Please tag the reviewers team in a comment below by prepending an @ in front of ACCESS-Hive/reviewers when ready.

@ccarouge ccarouge added the 🔧 new feature Brand new feature or updates to an existing one label Oct 5, 2022
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

PR Preview Action v1.1
Preview removed because the pull request was closed.
2022-10-05 00:47 UTC

@ccarouge ccarouge added 🔧 new feature Brand new feature or updates to an existing one and removed 🔧 new feature Brand new feature or updates to an existing one labels Oct 5, 2022
@ccarouge
Copy link
Member Author

ccarouge commented Oct 5, 2022

I've tested the behaviour when labelling the issue. The preview didn't build on creation of the PR, the action is skipped. Then, it builds when the label is added. If we remove and add the label again, it triggers a rebuild. As a safeguard, we can remove the label if a review requests a change and add it back on once the new commits have been checked.

@ccarouge ccarouge marked this pull request as ready for review October 5, 2022 00:43
@ccarouge ccarouge requested a review from rbeucher October 5, 2022 00:44
Copy link
Member

@rbeucher rbeucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @ccarouge !

@rbeucher rbeucher merged commit 73cb30b into main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 new feature Brand new feature or updates to an existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR preview not building for members without write access
2 participants