Support #35523 - Migrate from tslint to eslint #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntext function - Updates tests using mount directly (not using context) to use react testing library instead. - Removed the deprecated mountWithAppContext. - Removed Enzyme jest setup.
…ntext function - Remove enzyme dependencies and rebuilt yarn lock. - Removed unused import
…ntext function - Removed duplicate mock_app_context file, now it's only one. - Renamed all mountWithAppContext2 to mountWithAppContext since it's the only one now.
…ntext function - Fixed a bunch of imports, now it's just "common-ui" for the mock context.
…ntext function - More fixes
…ntext function - Fixed snapshots, now it's properly using the correct localization so it changes what is displayed as text. - Fixed import
…ntext function - Another snapshot fix.
- Added eslint to the project using the eslint installer. - Changed the lint scripts to use eslint. - Upgraded typescript to a supported version. - Currently I have no rules being applied, next I will be bringing over all the rules form the tslint configuration.
- Updated the eslint configuration to be include most of the tslint rules - Added ignores to not scan through node_modules or next.js specific files. - Added prettier support for eslint. - Removed tslint dependencies. - Changed lint-staged to use eslint instead. - Removed all tslint ignore rules for now, will add the eslint ones if required.
- Fixed issue with vscode not detecting the config file since it's looking in the packages folders. - Updated the docs to include the eslint extension. - Also included in the .vscode/extensions so vscode will recommend installing it.
…from-tslint-to-eslint
johnphan96
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.