Support #35239 - Molecular analysis workflow improvements #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a test for step 2 to ensure it saves properly and the step is working.
- Completed test coverage for step 2.
- Mocked all the mock requests/reponses to it's own file. - Started working on the step 4 tests.
- Finished step 4 molecular analysis run tests.
- Fixed import issue with grid step. - Started working on step 3 test coverage.
- Added skip button if no storage coordinates are saved. - Updated test coverage. - Updated mocks.
- Added a new info message if no storage coordinates exist yet when you switch to view mode. - Fixed layout for skip button. - More test coverage. - Fixed issue with cancel not switching to view in some cases and not clearing unsaved changes.
- Finished adding test coverage for step 3. Test coverage complete.
- List page now displays the proper label for analysis type.
- Added a warning popup to make sure you want to clear the grid if changing the storage unit type. - Updated the test to ensure the popup appears and clears the grid automatically. - Added more test cases. - Fixed issues with the mock.
- Fixed layout of the popup. - Fixed issue with the error reporting. - Fixed tests.
…ort-35239-Molecular-Analysis-Workflow-Improvements
johnphan96
approved these changes
Dec 2, 2024
johnphan96
deleted the
Support-35239-Molecular-Analysis-Workflow-Improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.