-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/edk2 202408 #333
Merged
Merged
Feat/edk2 202408 #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature
New feature or request
docker
docker related
dependencies
Pull requests that update a dependency file
github_actions
Pull requests that update GitHub Actions code
python
Pull requests that update Python code
labels
Sep 17, 2024
AtomicFS
force-pushed
the
feat/edk2-202408
branch
from
September 17, 2024 23:44
7a87076
to
9695f38
Compare
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Sep 17, 2024
AtomicFS
force-pushed
the
feat/edk2-202408
branch
2 times, most recently
from
September 19, 2024 09:36
f41787f
to
873beb5
Compare
AtomicFS
force-pushed
the
feat/edk2-202408
branch
3 times, most recently
from
September 23, 2024 14:24
d03ffdc
to
187ddf2
Compare
Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
AtomicFS
force-pushed
the
feat/edk2-202408
branch
2 times, most recently
from
September 23, 2024 18:20
f95a3a5
to
f1861e5
Compare
Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
AtomicFS
force-pushed
the
feat/edk2-202408
branch
from
September 23, 2024 19:47
f1861e5
to
0adf7ac
Compare
AtomicFS
force-pushed
the
feat/edk2-202408
branch
from
September 24, 2024 09:30
a4a2d2d
to
f150e1f
Compare
- timeouts are specific to the container type being built, this is because the time varies a lot Signed-off-by: AtomicFS <[email protected]>
AtomicFS
force-pushed
the
feat/edk2-202408
branch
from
September 24, 2024 12:53
e0a89c9
to
e346651
Compare
- the testing takes up too much space at the moment because of tarball export and import which is completely unnecessary - edk2 containers take up around 2.1 GB, combined with export and import that means 3x2.1 GB which overflows GitHubs 14 GB disk space - we should switch to dagger way of branching off a separate container for testing (just like we do for interactive mode) Signed-off-by: AtomicFS <[email protected]>
AtomicFS
force-pushed
the
feat/edk2-202408
branch
from
September 24, 2024 13:09
e346651
to
75e8e37
Compare
@MDr164 this should work now. Review pls. |
MDr164
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR text explains well enough why those TODO changes had been necessary so I'd say this is good to go under the current circumstances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
docker
docker related
documentation
Improvements or additions to documentation
feature
New feature or request
github_actions
Pull requests that update GitHub Actions code
module/edk2
python
Pull requests that update Python code
testing
Testing related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must be merged after #332
So I tried to add new
edk2-stable202408
container and oh boy, there was a lot to do. Pardon me but I will be a bit verbose here (mostly for sake of future me):dagger
issue, so I added more helpful error messages. And while doing that I also removed some old Python code that seemed to be useless.edk2-platforms
andedk2-non-osi
repositories toedk2
, but this required changes in theDockerfile
s andcompose.yaml
.UDK2017
was a problematic one. There is a tagUDK2017
and branchvUDK2017
and they are completely different. And of course I did accidentally (again) switch from functionalUDK2017
branch to brokenvUDK2017
tag by using wrong commit hash incompose.yaml
. This time I noticed what was the actual problem which allowed me to use this disk-saving approach.edk2
container, while all previous ones worked fine. I was informed that this is caused by recent change that requires-D BUILD_ARCH=X64
to be added to the build command. Thankfully this does not cause problems in old containers.