mali450-userland: use hardlinks instead of symlinks to fix the issue with RPM packaging #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we're doing the symlinking ourselves anyway, it's a decent workaround. Can you check these are still hardlinks on the target after installing? |
|
isn't it a bug in rpm? |
|
Yes, they are still hardlinks on the target. |
|
For me it looks like an rpm bug. And I need to fix builds for HiKey this or another way :) |
|
@andrey-konovalov do you mind to add some text in the recipe to mention the issue encountered ln -sf vs ln -f . Something similar to the commit message will do. Also, drop workaround from $subject. And it isn't specific to LHG builds. RPB builds are affected. So I'll remove also this part. |
andrey-konovalov
changed the title
rpm doesn't set the correct arch for symlinks: 96boards#156 Signed-off-by: Andrey Konovalov <[email protected]>
andrey-konovalov
force-pushed
the
issue-156-workaround
branch
from
c364a01 to
43a1aad
Compare
|
@fboudra updated the commit - added the comment to the recipe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #156
This is needed to fix builds which use RPM package format for HiKey, RPB and RPB based builds in particular. E.g. RPB build 71 :
Computing transaction...error: Can't install glmark2-2014.03+0+fa71af2dfa-r0@aarch64: no package provides libEGL.so()(64bit)