Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: delete-removed 옵션 true로 추가 #7

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

kdkdhoho
Copy link

개요

  • CD workflow 상에서 S3로 올리는 과정 중, delete-removed 옵션을 true로 추가했습니다.
    • delete-removed: Removes files in S3, that are not available in the local copy of the directory
    • S3에 올라가있지만, Github Repository(local)에서는 제거된 파일을 S3에서도 제거하는 옵션.. 으로 이해했습니다!
    • 그래서 켰습니다.


작업 사항

  • CD workflow에 delete-removed 옵션을 true로 추가

참고 사항 (optional)


관련 이슈 (optional)


스크린샷


리뷰어에게


Copy link
Contributor

@seoyoung-min seoyoung-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 감사합니다!👍🙇‍♀️

Copy link
Contributor

@Eugene-A-01 Eugene-A-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오,,, 이런것까지 서영님은 어찌 아셨는지
동호님 반영 감사합니다
저도 좋습니다👍👍

Copy link
Contributor

@Nahyun-Kang Nahyun-Kang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 감사합니다👏👏

@seoyoung-min seoyoung-min merged commit e09aa56 into dev Feb 3, 2024
1 check passed
@Eugene-A-01 Eugene-A-01 deleted the infra/cd-add-option branch March 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants