Feat: 검색 및 콜렉션 페이지 구현 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into feature/explore_search_component # Conflicts: # src/app/search/_components/SearchBar.tsx
…ch_component # Conflicts: # public/icons/crown.svg # src/app/page.tsx # src/lib/constants/queryKeys.ts
…ch_component # Conflicts: # src/lib/constants/queryKeys.ts
auto-assign
bot
requested review from
Eugene-A-01,
Nahyun-Kang,
ParkSohyunee and
seoyoung-min
|
@kanglocal is attempting to deploy a commit to the Eujin Ahn's projects Team on Vercel. A member of the Team first needs to authorize it. |
Nahyun-Kang
reviewed
Feb 23, 2024
|
|
||
| return response.data; | ||
| } | ||
|
|
There was a problem hiding this comment.
저도 몰랐는데 api 함수는 화살표 함수라고 합니당..🥹 나중에 리팩토링 할 때 대대적으로 바꿔도 좋을 것 같습니다!!
Nahyun-Kang
approved these changes
Feb 23, 2024
Nahyun-Kang
reviewed
Feb 23, 2024
| ) : ( | ||
| // 데이터가 없는 경우 | ||
| <NoData /> | ||
| )} |
There was a problem hiding this comment.
주석을 달아주셔서 알기 쉽네용..!!👍👍
Nahyun-Kang
reviewed
Feb 23, 2024
| @@ -0,0 +1,291 @@ | |||
| export const searchResult = { | |||
There was a problem hiding this comment.
저희 이제 목데이터는 지워도 되지 않을까요..?!👀
There was a problem hiding this comment.
오잉!! 이게있었네요 감사합니다!!
Nahyun-Kang
reviewed
Feb 23, 2024
| <div className={styles.collectWrapper}> | ||
| {data.isCollected ? <CollectedIcon onClick={handleCollect} /> : <CollectIcon onClick={handleCollect} />} | ||
| </div> | ||
| </> |
Eugene-A-01
approved these changes
Feb 23, 2024
Nahyun-Kang
reviewed
Feb 23, 2024
| handleSetOff: () => set({ isOn: false }), | ||
| })); | ||
|
|
||
| export default useModalState; |
There was a problem hiding this comment.
모달 전역 상태관리로 만들어주셨군요..! 감사합니다 👍👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
참고 사항 (optional)
관련 이슈 (optional)
추가 작업 예정
스크린샷
검색 페이지
콜렉션 페이지
리뷰어에게
그러니 힘드시지 않게 짧게 봐주시길 바랍니다...!
작은 문제점/개선점 이라도 발견하신다면 말씀부탁드립니다!