Feat: 히스토리 페이지 Ver3.0 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
kanglocal,
Nahyun-Kang,
ParkSohyunee and
seoyoung-min
|
@Eugene-A-01 is attempting to deploy a commit to the Eujin Ahn's projects Team on Vercel. A member of the Team first needs to authorize it. |
ParkSohyunee
approved these changes
Oct 31, 2024
Comment on lines
+15
to
+26
|
|
||
| selectors: { | ||
| '&::-webkit-scrollbar': { | ||
| height: '5px', | ||
| background: vars.color.bggray, | ||
| borderRadius: '6px', | ||
| }, | ||
| '&::-webkit-scrollbar-thumb': { | ||
| backgroundColor: vars.color.lightgray, | ||
| borderRadius: '6px', | ||
| }, | ||
| }, |
Comment on lines
+60
to
+77
| useEffect(() => { | ||
| const loadGoogleCharts = () => { | ||
| const script = document.createElement('script'); | ||
| script.src = 'https://www.gstatic.com/charts/loader.js'; | ||
| script.onload = () => { | ||
| if (window.google && window.google.charts) { | ||
| window.google.charts.load('current', { packages: ['corechart'] }); | ||
| window.google.charts.setOnLoadCallback(() => { | ||
| if (window.google.visualization?.LineChart) { | ||
| drawChart(); | ||
| window.addEventListener('resize', drawChart); | ||
| } else { | ||
| setTimeout(drawChart, 100); | ||
| } | ||
| }); | ||
| } | ||
| }; | ||
| document.body.appendChild(script); |
There was a problem hiding this comment.
유진님, char.js 패키지를 설치하지 않고, script 태그를 추가하는 방법으로 선택하신 이유가 궁금합니다..! 👀
There was a problem hiding this comment.
공홈 Getting Start를 보고 따라했는데, yarn add 해서 쓰는 방법도 있었군요!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
참고 사항
스크린샷
[그래프 탭]
[버전 탭]
리뷰어에게