Design: 마이페이지 설정으로 이름 변경 및 font, theme ver3.0 적용 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seoyoung-min
requested review from
Eugene-A-01,
kanglocal,
ParkSohyunee and
Nahyun-Kang
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ParkSohyunee
approved these changes
Oct 28, 2024
src/components/Header/Header.tsx
Outdated
Comment on lines
27
to
31
| <h1 className={`${styles.headerTitle} ${styles.flexChild}`}>{title}</h1> | ||
|
|
||
| <div className={`${styles.flexChild} ${styles.rightChild}`}>{right}</div> | ||
| {right === null ? <></> : <div className={`${styles.flexChild} ${styles.rightChild}`}>{right}</div>} | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
서영님, right이 null일때 Fragment를 추가해 둔 이유가 궁금합니다~!
There was a problem hiding this comment.
소현님 저도 제가 왜그랬는지 궁금합니다..! 이 점 반영하여 리팩토링 하였고, 페이지 디자인 다시 하여 수정하였습니다~!
그리고 git push도 upstream으로 곧바로 해버렸네요ㅠㅠ 이번에는 머지 후 지우고, 다음부터는 origin push 후에 PR 올리겠습니다~!
There was a problem hiding this comment.
서영님 새로 반영한 디자인 너무 보기 좋아요!! 👍 또, 드롭다운이 아닌 토글모양 선택도 직관적으로 옵션을 보여주는 것 같아요✨ 역시 최고입니다!!🥹
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
참고 사항 (optional)
관련 이슈 (optional)
스크린샷
⬇︎ 다시 디자인 한 버전
리뷰어에게