Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: 트렌딩리스트 에러 해결 #250

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

Nahyun-Kang
Copy link
Contributor

개요

  • 개요는 변경 사항 및 관련 이슈에 대해 간단하게 작성해주세요.
  • 해당 PR에 대한 리뷰어와 라벨을 생성해 주세요.

작업 사항

  • 트렌딩 리스트가 10개 이하일 때의 예외 처리를 해주었습니다.
  • 하드코딩된 탐색 페이지 코드를 최적화 하였습니다.

스크린샷

image


리뷰어에게

  • 어떤 부분에 리뷰어가 집중하면 좋을지
  • Swiper 라이브러리의 경우, loop 옵션이 켜져 있어도 슬라이드 개수가 적으면 순환이 제대로 되지 않는 경우가 있다고 합니다. 따라서 추가로 슬라이드를 생성해주었습니다.

@Nahyun-Kang Nahyun-Kang added the Fix 에러/버그 해결 label Jul 25, 2024
@Nahyun-Kang Nahyun-Kang self-assigned this Jul 25, 2024
Copy link

vercel bot commented Jul 25, 2024

@Nahyun-Kang is attempting to deploy a commit to the Eujin Ahn's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@seoyoung-min seoyoung-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나현님 빠르게 대응해주셔서 감사합니다🥹🫶

@Nahyun-Kang Nahyun-Kang changed the base branch from main to dev July 29, 2024 12:06
@Eugene-A-01 Eugene-A-01 merged commit 34fbeea into 8-Sprinters:dev Aug 11, 2024
1 of 2 checks passed
@Nahyun-Kang Nahyun-Kang deleted the Hotfix/explore branch August 18, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix 에러/버그 해결
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants