Refactor: refreshToken 만료시간 재설정 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkSohyunee
requested review from
Eugene-A-01,
kanglocal,
Nahyun-Kang and
seoyoung-min
|
@ParkSohyunee is attempting to deploy a commit to the Eujin Ahn's projects Team on Vercel. A member of the Team first needs to authorize it. |
Nahyun-Kang
approved these changes
May 17, 2024
Nahyun-Kang
reviewed
May 17, 2024
| @@ -35,7 +35,7 @@ export default function KakaoRedirectPage() { | |||
| }); | |||
|
|
|||
| const { id, accessToken, refreshToken } = res.data; | |||
| updateUser({ id, accessToken: '' }); // TODO id만 저장하기 | |||
| updateUser({ id }); | |||
There was a problem hiding this comment.
오오 혹시 accessToken 토큰 쿠키로 옮기셔서 지우시는 건가요?! 👁️
There was a problem hiding this comment.
아니요 나현님!! 사용자 정보를 id만 저장하고 있기 때문에 사용하지 않는 코드라서 삭제합니당 🥹🥲
Eugene-A-01
added a commit
that referenced
this pull request
Jun 5, 2024
…247) * Fix: 댓글 기능 추가(댓글 줄바꿈 표시, 비회원 댓글창 클릭시 로그인 모달, 답글 작성자 프로필 클릭 로직 추가), 인트로 페이지 영상 ios 자동재생 문제 테스트 (#242) * Feat: 답글 프로필 클릭시 해당 유저 마이리스트 페이지도 이동하도록 하는 기능 구현 * Fix: 비회원 댓글창 클릭시 로그인 모달 뜨게 구현 * Feat: textarea 출력시 줄바꿈 인식되게 수정 * Fix: 인트로 페이지 영상 ios에서 자동재생 안되는 문제 (테스트) * Fix: 답글도 줄바꿈 되도록 수정 * Fix: 댓글 작성 폼 모달 GTM id 수정 * Refactor: refreshToken 만료시간 재설정 (#241) * Style: 주석 정리 * Feat: useUser store에 사용하지 않는 accessToken 저장 로직 삭제 (사용자 id값만 저장되도록 수정) * Feat: refreshToken 쿠키 만료시간 재설정 * Feat: 개인정보 처리방침 페이지 연결 추가 * fix: 콜렉션 페이지 bottom nav에 가려지는 하단부 여백 추가 --------- Co-authored-by: 강나현 <[email protected]> Co-authored-by: Sohyun Park <[email protected]> Co-authored-by: Seoyoung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
참고 사항 (optional)
리뷰어에게