Feat: 카카오 OAuth 로그인 기능 구현 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkSohyunee
requested review from
Eugene-A-01,
kanglocal,
Nahyun-Kang and
seoyoung-min
|
@ParkSohyunee is attempting to deploy a commit to the Eujin Ahn's projects Team on Vercel. A member of the Team first needs to authorize it. |
Nahyun-Kang
approved these changes
Feb 8, 2024
Eugene-A-01
approved these changes
Feb 8, 2024
src/store/useUser.ts
Outdated
There was a problem hiding this comment.
오와,, store이라는 폴더명이 낯설어서 주스탠드 공식문서 보고왔는데
소현님께서 파일명, 폴더이름, export이름 까지 공식문서 내용이랑 같아서 상세한 곳 하나하나 다 신경쓰신게 느껴지네요,,
정말 깔끔합니다 LGTM!
Comment on lines
+36
to
+42
| if (error instanceof AxiosError) { | ||
| if (!controller.signal.aborted) { | ||
| console.error(error.message); | ||
| } else { | ||
| console.log('Request canceled:', error.message); | ||
| } | ||
| } |
There was a problem hiding this comment.
소현님 요청취소 구현하신거 보고 처음 알아갑니다!
로그인 과정에서 요청을 취소하게 되는 상황이 있어서 구현하신건가요?
어떨때 필요해서 구현하신건지 단순히 궁금했습니다!
There was a problem hiding this comment.
유진님! 맞습니다~! useEffect 콜백함수에서 api 요청을 보내고 있는데 중복으로 호출되는 문제가 있어서 remount가 될 때 이전 api 요청에 대해서는 취소처리가 필요하여 구현하였습니다. 자세한 내용은 관련 이슈에 남겨 놓았습니다. 참고 부탁드립니다~!😊
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seoyoung-min
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
참고 사항 (optional)
관련 이슈 (optional)
스크린샷
리뷰어에게
ㄴ 완료시점에 다시 한번 노티드리겠습니다.