Feat: 마이피드 접근 시, 에러 케이스(탈퇴 / 잘못된id 입력 / 없는 사용자)에 따른 에러처리 로직 추가 #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkSohyunee
requested review from
Eugene-A-01,
kanglocal,
Nahyun-Kang and
seoyoung-min
|
@ParkSohyunee is attempting to deploy a commit to the Eujin Ahn's projects Team on Vercel. A member of the Team first needs to authorize it. |
Closed
Comment on lines
+37
to
+50
| // 탈퇴한 회원이거나(400), 잘못된 id거나(400), 없는 회원(404)인 경우 에러처리 | ||
| if (isError && error instanceof AxiosError) { | ||
| return ( | ||
| <Modal size="basic" handleModalClose={onClickMoveToPage('/')}> | ||
| <Modal.Title>{error.response?.data.detail}</Modal.Title> | ||
| <div className={modalStyles.buttonContainer}> | ||
| <button type="button" className={modalStyles.button.primary} onClick={onClickMoveToPage('/')}> | ||
| 확인 | ||
| </button> | ||
| </div> | ||
| </Modal> | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
리액트 쿼리와 에러 처리는 이렇게 하는 거군요!!
꼼꼼하게 처리해주시는 소현님 덕에 한층 더 진짜 서비스 다워지고 있는 것 같아요!🤩👍
넘 감사합니다 💗
+) 소현님!! 이거 Modal.SingleButton으로 하나짜리 버튼 구현되어있어 그거 사용해도 좋을 것 같아요!!
<Modal.Title>제목</Modal.Title>
<Modal.SigleButton>확인</Modal.SigleButton>
There was a problem hiding this comment.
리액트 쿼리와 에러 처리는 이렇게 하는 거군요!! 꼼꼼하게 처리해주시는 소현님 덕에 한층 더 진짜 서비스 다워지고 있는 것 같아요!🤩👍 넘 감사합니다 💗
+) 소현님!! 이거 Modal.SingleButton으로 하나짜리 버튼 구현되어있어 그거 사용해도 좋을 것 같아요!! <Modal.Title>제목</Modal.Title> <Modal.SigleButton>확인</Modal.SigleButton>
오! 서영님 한개버튼을 찾고 있었는데 싱글버튼이 있었군요!! (예전에 서영님 pr에서 본 것 같군요!!😂)
감사합니당 서영님~ 수정하겠습니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
참고 사항 (optional)
스크린샷
리뷰어에게