Fix: 코드리뷰 반영

8-Sprinters · Oct 29, 2024 · 97a2685 · 97a2685
1 parent ff3c572
commit 97a2685
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 113 deletions.
diff --git a/src/app/notices/[noticeId]/NoticeDetail.css.ts b/src/app/notices/[noticeId]/NoticeDetail.css.ts
@@ -4,26 +4,23 @@ import { vars } from '@/styles/theme.css';
 export const titleSection = style({
   padding: '25px 16px 40px',
 
-  backgroundColor: '#3D95FF',
-});
-
-export const categoryList = style({
   display: 'flex',
-  flexDirection: 'row',
-  gap: '4px',
+  flexDirection: 'column',
+
+  backgroundColor: '#3D95FF',
 });
 
 export const category = style({
   padding: '6px 12px',
-  marginBottom: '12px',
 
   backgroundColor: vars.color.white,
   fontSize: '1.4rem',
   color: vars.color.bluegray8,
-  borderRadius: '9999px',
+  borderRadius: '16px',
 });
 
 export const title = style({
+  marginTop: '14px',
   marginBottom: '11px',
 
   color: vars.color.white,

diff --git a/src/app/notices/[noticeId]/NoticeDetail.tsx b/src/app/notices/[noticeId]/NoticeDetail.tsx
@@ -12,13 +12,9 @@ function NoticeDetailComponent() {
   return (
     <>
       <section className={styles.titleSection}>
-        <ul className={styles.categoryList}>
-          {data.category.map((el, idx) => (
-            <li key={idx.toString()}>
-              <div className={styles.category}>{el}</div>
-            </li>
-          ))}
-        </ul>
+        <div>
+          <span className={styles.category}>{data.category}</span>
+        </div>
         <h3 className={styles.title}>{data.title}</h3>
         <div className={styles.titleSectionDescription}>{data.description}</div>
         <p className={styles.titleSectionCreatedDate}>{data.createdDate}</p>

diff --git a/src/app/notices/mockdata.ts b/src/app/notices/mockdata.ts
@@ -6,62 +6,62 @@ export const NOTICE_LIST_MOCKDATA: NoticeListItemType[] = [
     createdDate: '2024-10-01',
     title: 'New Feature Release',
     itemImageUrl: null,
-    category: ['공지'],
+    category: '소식',
     description: 'We have released a new feature that will enhance your experience.',
   },
   {
     id: 2,
     createdDate: '2024-09-28',
     title: 'Scheduled Maintenance',
     itemImageUrl: 'https://singlesumer.com/files/attach/images/138/863/046/f787f76706d1b00f77ea67d4d2b833f4.jpg',
-    category: ['공지'],
+    category: '이벤트',
     description: 'The system will undergo maintenance on October 5th. Please be aware of potential downtime.',
   },
   {
     id: 3,
     createdDate: '2024-09-25',
     title: 'Holiday Event',
     itemImageUrl: 'https://singlesumer.com/files/attach/images/138/863/046/f787f76706d1b00f77ea67d4d2b833f4.jpg',
-    category: ['이벤트&뉴스'],
+    category: '팁',
     description: 'Join our special holiday event starting October 10th with exciting offers!',
   },
   {
     id: 4,
     createdDate: '2024-09-22',
     title: 'Security Update',
     itemImageUrl: 'https://singlesumer.com/files/attach/images/138/863/046/f787f76706d1b00f77ea67d4d2b833f4.jpg',
-    category: ['공지'],
+    category: '소식',
     description: 'We have implemented new security protocols to better protect user data.',
   },
   {
     id: 5,
     createdDate: '2024-09-18',
     title: '5 Tips to Maximize Productivity',
     itemImageUrl: 'https://singlesumer.com/files/attach/images/138/863/046/f787f76706d1b00f77ea67d4d2b833f4.jpg',
-    category: ['팁'],
+    category: '팁',
     description: 'Learn how to improve your productivity with these simple tips.',
   },
   {
     id: 6,
     createdDate: '2024-09-15',
     title: 'Server Downtime Resolved',
     itemImageUrl: null,
-    category: ['공지'],
+    category: '이벤트',
     description: 'The recent server issue has been resolved. All systems are back online.',
   },
   {
     id: 7,
     createdDate: '2024-09-10',
     title: 'New Blog Post Available',
     itemImageUrl: 'https://singlesumer.com/files/attach/images/138/863/046/f787f76706d1b00f77ea67d4d2b833f4.jpg',
-    category: ['이벤트&뉴스'],
+    category: '소식',
     description: 'Check out our latest blog post on the importance of cybersecurity.',
   },
 ];
 
 export const NOTICE_DETAIL_MOCKDATA: NoticeDetailType = {
   id: 1,
-  category: ['공지', '팁'],
+  category: '소식',
   title: '서비스 점검 안내',
   description: '서비스 점검이 10월 20일에 진행될 예정입니다.',
   content: [

diff --git a/src/components/BottomNav/__BottomNav.tsx b/src/components/BottomNav/__BottomNav.tsx
diff --git a/src/lib/types/noticeType.ts b/src/lib/types/noticeType.ts
@@ -3,13 +3,13 @@ export interface NoticeListItemType {
   createdDate: string;
   title: string;
   itemImageUrl: string | null;
-  category: string[];
+  category: string;
   description: string;
 }
 
 export interface NoticeDetailType {
   id: number;
-  category: string[];
+  category: string;
   title: string;
   description: string;
   content: NoticeContentType[];