feat: 탐색 페이지 트랜딩 리스트 조회 API 구현 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kdkdhoho
reviewed
Feb 7, 2024
src/main/java/com/listywave/list/presentation/dto/response/ListTrandingResponse.java
Outdated
Show resolved
Hide resolved
| .map(item -> item.getImageUrl()) | ||
| .filter(url -> !url.isEmpty()) | ||
| .findFirst() | ||
| .orElse(""); |
There was a problem hiding this comment.
만약 Item에 imageUrl 값이 존재하지 않으면 "" 로 저장되어 있는 걸로 알고 있습니다.
그렇다면 orElse() 문은 필요없을 것 같아요!
There was a problem hiding this comment.
동호님 혹시 orElse를 안하면 최종 결과가 Optional.empty()가 반환되는 거로 알고있어서그러는데 어떻게 해야할 까요.. orElse없이는 반환이 Optional이고 그냥 마지막에 get() 해야하나요
src/main/java/com/listywave/list/presentation/dto/response/ListTrandingResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/com/listywave/list/repository/list/custom/impl/CustomListRepositoryImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/listywave/list/repository/list/custom/impl/CustomListRepositoryImpl.java
Show resolved
Hide resolved
src/main/java/com/listywave/list/repository/list/custom/impl/CustomListRepositoryImpl.java
Show resolved
Hide resolved
src/main/java/com/listywave/list/application/service/ListService.java
Outdated
Show resolved
Hide resolved
kdkdhoho
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reference
Relation Issues