feat: 카카오 로그아웃 API 구현 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
pparkjs
approved these changes
Feb 7, 2024
Comment on lines
+36
to
+40
| User user = User.initialCreate( | ||
| kakaoMember.id(), | ||
| kakaoMember.kakaoAccount().email(), | ||
| kakaoTokenResponse.accessToken() | ||
| ); |
There was a problem hiding this comment.
해당부분은 kakao에서 가져온 카카오 유저가 실제 우리 서비스에 가입한 유저가 아니면 회원가입을 시키는 과정인거죠!? 그리고 로그아웃을 위해 accessToken저장을 위해 별도 추가하신거고
| @PatchMapping("/auth/kakao") | ||
| ResponseEntity<Void> logout(@RequestHeader(value = AUTHORIZATION) String accessToken) { | ||
| authService.logout(accessToken); | ||
| return ResponseEntity.noContent().build(); |
There was a problem hiding this comment.
이부분은 프론트단이 accessToken가지고 해당 uri로 요청하는 거죠?
Comment on lines
+51
to
+55
| public void logout(String accessToken) { | ||
| Long userId = jwtManager.read(accessToken); | ||
| User user = userRepository.getById(userId); | ||
| kakaoOauthClient.logout(user.getKakaoAccessToken()); | ||
| } |
There was a problem hiding this comment.
아하 카카오에서 발급한 AccessToken을 테이블에 저장한 이유가 여기있었군요
| @@ -28,18 +24,17 @@ public class UserService { | |||
|
|
|||
| @Transactional(readOnly = true) | |||
| public UserInfoResponse getUserInfo(Long userId, String accessToken) { | |||
| Optional<User> found = userRepository.findById(userId); | |||
| User foundUser = found.orElseThrow(() -> new CustomException(NOT_FOUND)); | |||
| User user = userRepository.getById(userId); | |||
There was a problem hiding this comment.
findById를 안하고 getById 하신 이유가 있나요!?
There was a problem hiding this comment.
service 단의 코드 간소화를 위해 했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
카카오 로그아웃 API 구현했습니다.
로그아웃 요청 시, 액세스 토큰 방식과 서비스 앱 어드민 키 방식으로 총 2가지 방식이 존재합니다.
서비스 앱 어드민 키 방식보다 액세스 토큰 방식이 쉽고 편하게 구현이 가능한 대신, 카카오에서 발급한 액세스 토큰을 DB에 저장해야 합니다.
아직 개발 단계이며 데이터가 많이 쌓이지 않았으므로 users 테이블에 함께 저장하도록 했습니다.
하지만 추후 따로 관리 할 필요가 있어보이며 해당 방법에 대해서는 고민해봐야겠습니다.
Reference
Relation Issues