Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 관리자용 요청 주제(토픽) 조회 및 수정 API 구현 #319

Closed
wants to merge 6 commits into from

Conversation

kdkdhoho
Copy link
Collaborator

@kdkdhoho kdkdhoho commented Oct 27, 2024

Description

#306 에 이어서 미리 작업을 진행했습니다.

변경 사항만 리뷰하시려면 이 링크를 눌러주세요.

Relation Issues

@kdkdhoho kdkdhoho self-assigned this Oct 27, 2024
@kdkdhoho kdkdhoho requested a review from pparkjs as a code owner October 27, 2024 05:50
@kdkdhoho kdkdhoho linked an issue Oct 27, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@pparkjs pparkjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 일단 관리자 권한 같은 로직은 안하신거죠!? 죽머지 이후에 차차 구현하실 예정이신가요?
코멘트 답변 동호님 판단하에 해주시길 바랍니다!
approve 드릴게요 수고하셨습니다 ㅎㅎ

@PutMapping("/admin/topics/{topicId}")
ResponseEntity<Void> update(@PathVariable Long topicId, @RequestBody TopicUpdateRequest request) {
topicService.update(topicId, request.isExposed(), request.categoryCode(), request.title());
return ResponseEntity.noContent().build();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

드디어 admin에 해당하는 api가..!

if (topics.size() > size) {
hasNext = true;
topics.remove(topics.size() - 1);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거또한 앞서 페이징유틸에서 사용하는 메서드 이용하실 수 있으면 하면 좋고 동호님 판단하에 해주시길 바랍니다 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

관리자용 요청 주제 조회, 노출 여부 수정, 수정 API 구현
2 participants